Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning: webauth.login → webauth.authorize #367

Merged
merged 1 commit into from
Mar 1, 2017

Conversation

dtinth
Copy link
Contributor

@dtinth dtinth commented Feb 26, 2017

webauth.redirect.loginWithCredentials will be soon deprecated, use webauth.login instead.

This is the warning when trying to use webauth.redirect.loginWithCredentials (which is still in the official docs. However, webauth.login is nowhere to be found.

However, 2a6ef04 renamed the .login() method to .authorize(). This pull request fixes the deprecation warning.

@codecov-io
Copy link

Codecov Report

Merging #367 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #367   +/-   ##
=======================================
  Coverage   97.61%   97.61%           
=======================================
  Files          35       35           
  Lines        1173     1173           
  Branches      195      195           
=======================================
  Hits         1145     1145           
  Misses         28       28
Impacted Files Coverage Δ
src/web-auth/redirect.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfe398b...0bf9ff4. Read the comment docs.

@dtinth
Copy link
Contributor Author

dtinth commented Feb 26, 2017

However I don’t know how to send the username and password through webAuth.authorize().

@hzalaz
Copy link
Member

hzalaz commented Feb 26, 2017

@dtinth you don't. That will redirect you to your auth0 account login page and there your user can enter their credentials.
If that is not good enough you can still use the method since it says it will be soon deprecated since we are exploring replacements beyond https://auth0.com/docs/libraries/auth0js#webauth-client-login- that is a simple xhr

@hzalaz
Copy link
Member

hzalaz commented Feb 26, 2017

Also thanks for the PR will merge when I am near my mac

@hzalaz hzalaz merged commit 2cf3091 into auth0:master Mar 1, 2017
@luisrudge luisrudge added this to the v8.4.0 milestone Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants