Fix inconsistent cross origin error handling #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 15, 2018
lbalmaceda
reviewed
Feb 15, 2018
| @@ -4,6 +4,7 @@ var windowHelper = require('../helper/window'); | |||
| var objectHelper = require('../helper/object'); | |||
| var RequestBuilder = require('../helper/request-builder'); | |||
| var WebMessageHandler = require('./web-message-handler'); | |||
| var responseHandler = require('../helper/response-handler'); | |||
There was a problem hiding this comment.
what convention are you following by using a lowercase for the first letter and a capital one for the WebMessageHandler?
There was a problem hiding this comment.
WebMessageHandler is a class, responseHandler is a function
lbalmaceda
suggested changes
Feb 15, 2018
| expect(err).to.be.eql({ error: 'any_error', error_description: 'any error' }); | ||
| expect(err).to.be.eql({ | ||
| original: { error: 'any_error', error_description: 'any error' }, | ||
| code: 'any_error', |
There was a problem hiding this comment.
I know that it's different any_error to any error, but can you please change one of them to something more visibly different? i.e. code: 'any_error', description: 'a long error description'
| error_description: '{"some":"error"}' | ||
| original: { | ||
| error: 'request_error', | ||
| error_description: '{"some":"error"}' |
There was a problem hiding this comment.
are you sure this particular error description is an object?
There was a problem hiding this comment.
it's a string, not an object.
There was a problem hiding this comment.
lbalmaceda
approved these changes
Feb 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't applying the error mapping that we do in other errors.