Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for /branding endpoints #475

Merged
merged 9 commits into from
Feb 15, 2021

Conversation

connorconway
Copy link
Contributor

Changes

Added support for the /branding endpoint (GET/PATCH)
Added support for the /branding/templates/universal-login endpoint (GET/DELETE/PUT)

References

Get Branding Docs
Patch Branding Docs
Get Universal Login Docs
Delete Universal Login Docs
Put Universal Login Docs

Testing

I added a reference to the assemblies within our deploy tool and tested retrieving and updating the branding, setting the universal login template, retrieving the universal login template, and deleting the universal login template.

  • This change adds unit test coverage

  • This change adds integration test coverage.
    -- Needed but I'm unable to write these

  • This change has been tested on the latest version of the platform/language

Checklist

@connorconway connorconway requested a review from a team as a code owner February 12, 2021 22:27
@connorconway connorconway changed the title Branding Adds support for /branding endpoints Feb 12, 2021
@frederikprijck
Copy link
Member

frederikprijck commented Feb 15, 2021

Thanks for the PR @connorconway . I added some integration tests and updated the docs.
There was also an issue with the UniversalLoginTemplateUpdateRequest object. It doesnt support the Body property, the payload needs to either be a string or an object with a Template property. (The docs aren't very clear on that).

@stevehobbsdev stevehobbsdev merged commit cfe69fd into auth0:master Feb 15, 2021
@frederikprijck frederikprijck added this to the vNext milestone Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants