Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure CustomDomainVerification.Methods can be serialized #509

Merged
merged 2 commits into from
Aug 12, 2021

Conversation

frederikprijck
Copy link
Member

The Methods property on the CustomDomainVerification type was defined as an array of strings, while its actually an array of objects, see https://auth0.com/docs/api/management/v2#!/Custom_Domains/get_custom_domains.

This PR doesn't add tests as we already have a test in place for this, but its configured to only run manually. I manually run the test to verify it works as expected now.

Fixes #508

@frederikprijck frederikprijck requested a review from a team as a code owner July 29, 2021 11:43
@frederikprijck frederikprijck merged commit c03e292 into master Aug 12, 2021
@frederikprijck frederikprijck deleted the fix/508 branch August 12, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CustomDomainVerification.Methods cannot be deserialized
2 participants