Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement automatic rate-limit handling #512

Merged
merged 6 commits into from
Aug 20, 2021
Merged

Implement automatic rate-limit handling #512

merged 6 commits into from
Aug 20, 2021

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Aug 16, 2021 •
edited
Loading

Adds automatic rate limit handling by retrying calls that result in a 429.

  • By default retries 3 times.
  • Amount of retries can be configured through setting NumberOfHttpRetries, which has to be a number between 0 and 10.
  • Using 0 disables retrying.

@frederikprijck frederikprijck force-pushed the frederik/sdk-2688 branch 4 times, most recently from 9f9fad3 to 57ec39b Compare August 17, 2021 12:48
@frederikprijck frederikprijck marked this pull request as ready for review August 17, 2021 12:51
@frederikprijck frederikprijck requested a review from a team as a code owner August 17, 2021 12:51
evansims
evansims previously approved these changes Aug 17, 2021
View reviewed changes
Copy link
Member

@evansims evansims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Thanks for all your work on this

@frederikprijck frederikprijck marked this pull request as draft August 18, 2021 11:24
@frederikprijck frederikprijck marked this pull request as ready for review August 20, 2021 09:06
@evansims evansims requested review from evansims and removed request for evansims August 20, 2021 12:56
evansims
evansims approved these changes Aug 20, 2021
View reviewed changes
Copy link
Member

@evansims evansims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 👍

@frederikprijck frederikprijck merged commit e20b81b into master Aug 20, 2021
@frederikprijck frederikprijck deleted the frederik/sdk-2688 branch August 20, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hawxy Hawxy Hawxy left review comments

@evansims evansims evansims approved these changes

Assignees
No one assigned
Labels
CH: Added large Large review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frederikprijck @evansims @Hawxy