Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-2719] Add support for Actions Management APIs #517

Merged
merged 6 commits into from
Aug 29, 2021
Merged

[SDK-2719] Add support for Actions Management APIs #517

merged 6 commits into from
Aug 29, 2021

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Aug 27, 2021 •
edited
Loading

Adds support for the Actions endpoints on API2.

@frederikprijck frederikprijck marked this pull request as ready for review August 27, 2021 14:02
@frederikprijck frederikprijck requested a review from a team as a code owner August 27, 2021 14:02
@frederikprijck frederikprijck added CH: Added review:medium Medium review review:large Large review and removed review:medium Medium review labels Aug 27, 2021
jimmyjames
jimmyjames requested changes Aug 27, 2021
View reviewed changes
Copy link

@jimmyjames jimmyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I don't see support for the deployed_version field of an Action. Oversight, or am I missing it?

@frederikprijck
Copy link
Member Author

Oversight 😮 , thanks for catching that @jimmyjames

@frederikprijck frederikprijck merged commit 763ba17 into master Aug 29, 2021
@frederikprijck frederikprijck deleted the frederik/sdk-2719 branch August 29, 2021 08:32
@frederikprijck frederikprijck mentioned this pull request Aug 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmyjames jimmyjames jimmyjames approved these changes

Assignees
No one assigned
Labels
CH: Added review:large Large review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frederikprijck @jimmyjames