Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auth0-forwarded-for header to passwordless sms authentication for… #530

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

rhyswilliamszip
Copy link
Contributor

@rhyswilliamszip rhyswilliamszip commented Oct 22, 2021

Changes

Please describe both what is changing and why this is important. Include:

This change is to add auth0-forwarded-for header for passwordless sms authentication for rate limit purposes as per

(https://auth0.com/docs/connections/passwordless/best-practices#link-accounts)

See section at the bottom

Setting the auth0-forwarded-for header for rate-limit purposes

References

Please include relevant links supporting this change such as a:

(https://auth0.com/docs/connections/passwordless/best-practices#link-accounts)

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

I have not included any additional tests as the existing method

public async Task<AccessTokenResponse> GetTokenAsync(ResourceOwnerTokenRequest request, CancellationToken cancellationToken = default)

already makes use of this but I could not find any specific tests for the ForwardedForIp field.

Further since this change is simply adding an additional header it shouldn't change the behaviour unless users start setting it.

Checklist

@rhyswilliamszip rhyswilliamszip requested a review from a team as a code owner October 22, 2021 07:57
@frederikprijck frederikprijck merged commit 2d56fe3 into auth0:master Oct 22, 2021
@frederikprijck frederikprijck added this to the 7.12.0 milestone Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants