Add support for Rules Configs endpoints #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! Let me first merge #550, then we can rebase your branch and get it reviewed and merged as well. |
Closed
|
Thanks very much. Please let me know if you need anything. I’ve been using Auth0 for a long time and I’m happy to be able to contribute.
jc
From: Frederik Prijck ***@***.***>
Sent: Monday, February 28, 2022 3:40 AM
To: auth0/auth0.net ***@***.***>
Cc: James Caldwell ***@***.***>; Author ***@***.***>
Subject: Re: [auth0/auth0.net] Features/rules configs management client (PR #552)
Thanks for this!
Let me first merge #550<#550>, then we can rebase your branch and get it reviewed and merged as well.
—
Reply to this email directly, view it on GitHub<#552 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ATA3OEXUT42U3T2OW7RCBETU5MYETANCNFSM5PH6CNEQ>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
|
|
Hey @caldwell0414 , Would you be able to resolve the conflicts? I just merged the other PR so you should be able to drop the cleanup commit, and merge in master. Thanks |
|
Sure thing. I’ll take care of that this morning and push an update.
jc
From: Frederik Prijck ***@***.***>
Sent: Wednesday, March 2, 2022 6:04 AM
To: auth0/auth0.net ***@***.***>
Cc: James Caldwell ***@***.***>; Mention ***@***.***>
Subject: Re: [auth0/auth0.net] Features/rules configs management client (PR #552)
Hey @caldwell0414<https://github.com/caldwell0414> ,
Would you be able to resolve the conflicts? I just merged the other PR so you should be able to drop the cleanup commit, and merge in master.
Thanks
—
Reply to this email directly, view it on GitHub<#552 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ATA3OEXDCBQMTYVZM36XUELU55DL3ANCNFSM5PH6CNEQ>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
…e v2 API, plus an initial integration test.
frederikprijck
force-pushed
the
features/rules-configs-management-client
branch
from
2f91e71
to
4b9ad14
Compare
frederikprijck
requested changes
Mar 4, 2022
frederikprijck
approved these changes
Mar 4, 2022
|
I update the base here, thanks! 🚀 |
frederikprijck
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added a new Client implementation to the ManagementApi named RulesConfigClient. This client will make calls to the /rules-configs endpoint in the Auth0 Management API (v2). It includes a PUT and a DELETE call. It does not include any GET requests because they are not supported on that endpoint for security purposes. Because the implementor cannot determine if a variable already exists, we have named the PUT implementation CreateOrUpdateAsync().
We followed the pattern provided for other clients in the library and included the great cleanup work done by @frederikprijck. His commit is included in our PR, so you may want to accept his first.
References
See Issue #551 for more details.
Testing
Our PR includes integration tests to exercise the new client.
This change adds unit test coverage
This change adds integration test coverage
This change has been tested on the latest version of the platform/language or why not
Checklist
I have read the Auth0 general contribution guidelines
I have read the Auth0 Code of Conduct
All existing and new tests complete without errors
NOTE: some tests require configuration that we don't have correct on our test host. please let us know if your testing runs into any critical failures. We did not modify any existing code and so do not expect any side effects.