Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add show_as_button to ConnectionBase.cs #647

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

dylanAtWork
Copy link
Contributor

Changes

show_as_button is missing from Connections in auth0.net but it exists in dumps from the deploy-cli as well as in other Auth0 packages like go-auth0. This PR adds it to ConnectionBase.cs

References

go-auth0 mentioned above:
https://github.com/auth0/go-auth0/blob/a98b898932cd024335fba6971c8a9d6853e9493c/management/connection.go#L129

I've got an application using this workaround for the time being:

    public class FixedConnectionCreateRequest : ConnectionCreateRequest
    {
        [JsonProperty("show_as_button")]
        public bool? ShowAsButton { get; set; }
    }

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

A good test to me would probably be to create a Connection with show_as_button set, or making a GET for an existing one

  • This change adds unit test coverage

  • This change adds integration test coverage

  • This change has been tested on the latest version of the platform/language or why not

Checklist

show_as_button is missing auth0.net for some reason, but it exists in dumps from the deploy-cli as well as in other Auth0 packages like go-auth0:

https://github.com/auth0/go-auth0/blob/a98b898932cd024335fba6971c8a9d6853e9493c/management/connection.go#L129
@dylanAtWork dylanAtWork requested a review from a team as a code owner August 21, 2023 16:22
@frederikprijck
Copy link
Member

I don't see this property being listed in the API docs:

I have reached out internally to understand why that property isn't documented. Typically it means that it should be used publicly, and should not be part of our SDK(s).

However, I will get back to this once I have more information.

@dylanAtWork
Copy link
Contributor Author

dylanAtWork commented Aug 23, 2023

That's odd, it's something new with Universal Login I think so maybe it was just missed?

it corresponds with this in the Admin UI
image

frederikprijck
frederikprijck previously approved these changes Sep 25, 2023
@frederikprijck
Copy link
Member

Thanks for the PR, sorry it took so long but I needed to get some information internally.

We will need to circle back to update XML docs here, but will merge.

@frederikprijck frederikprijck enabled auto-merge (squash) September 25, 2023 09:04
@frederikprijck frederikprijck merged commit 0ef6335 into auth0:master Sep 25, 2023
5 of 6 checks passed
@frederikprijck frederikprijck mentioned this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants