Add show_as_button to ConnectionBase.cs #647
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
show_as_button
is missing from Connections in auth0.net but it exists in dumps from the deploy-cli as well as in other Auth0 packages like go-auth0. This PR adds it to ConnectionBase.csReferences
go-auth0 mentioned above:
https://github.com/auth0/go-auth0/blob/a98b898932cd024335fba6971c8a9d6853e9493c/management/connection.go#L129
I've got an application using this workaround for the time being:
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
A good test to me would probably be to create a Connection with show_as_button set, or making a GET for an existing one
This change adds unit test coverage
This change adds integration test coverage
This change has been tested on the latest version of the platform/language or why not
Checklist
I have read the Auth0 general contribution guidelines
I have read the Auth0 Code of Conduct
All existing and new tests complete without errors