Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Params type exported #308

Closed
vitaliyazvinski opened this issue Dec 8, 2022 · 1 comment
Closed

Make Params type exported #308

vitaliyazvinski opened this issue Dec 8, 2022 · 1 comment

Comments

@vitaliyazvinski
Copy link
Contributor

Describe the problem you'd like to have solved

Params type of middleware function is not exportable

Describe the ideal solution

Mark it with export:
export type Params

Additional context

It was possible to import it in 6.1.* which was very useful in creating wrappers around given middleware
@petermetz
Copy link

Yes, please! My upgrade path from 6.x to 7.x would've been very simple if the Params type got exported in 7.x.

@petermetz petermetz mentioned this issue Dec 9, 2022
Closed
vitaliyazvinski added a commit to vitaliyazvinski/express-jwt that referenced this issue Dec 9, 2022
@vitaliyazvinski
feat: export middleware options type. closes auth0#308
3fdd21d
@vitaliyazvinski vitaliyazvinski mentioned this issue Dec 9, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@petermetz @vitaliyazvinski