Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: genid function as async #463

Closed
Will956 opened this issue Apr 19, 2023 · 2 comments
Closed

Question: genid function as async #463

Will956 opened this issue Apr 19, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@Will956
Copy link
Contributor

Will956 commented Apr 19, 2023

Describe the problem you'd like to have solved

Hey 👋

I was just wondering if there is any specific reason to not have the genid function async?

We can probably have some async operation to generate IDs, so it can not be used for this at the moment.

Thanks 🙌
@adamjmcgrath
Copy link
Contributor

Hey @Will956

Yep - good point, it should be async. Not sure when I'll get round to adding this, but happy to accept a PR in the meantime.

@adamjmcgrath adamjmcgrath added the enhancement New feature or request label Apr 19, 2023
@Will956 Will956 mentioned this issue Apr 19, 2023
Merged
3 tasks
@adamjmcgrath
Copy link
Contributor

This got published in https://github.com/auth0/express-openid-connect/releases/tag/v2.15.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adamjmcgrath @Will956