Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make genid async #464

Merged
merged 2 commits into from
Apr 19, 2023
Merged

Make genid async #464

merged 2 commits into from
Apr 19, 2023

Conversation

Will956
Copy link
Contributor

@Will956 Will956 commented Apr 19, 2023 •
edited
Loading

Description

Turn genid to async in order to use async operations to generate a custom id.

References

Linked to #463.

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@Will956 Will956 marked this pull request as ready for review April 19, 2023 15:42
@Will956 Will956 requested a review from a team as a code owner April 19, 2023 15:42
@Will956
Copy link
Contributor Author

Will956 commented Apr 19, 2023

@adamjmcgrath This is my try about making genid async - let me know if you need me to make any additional changes for that. Thanks 🙏

adamjmcgrath
adamjmcgrath reviewed Apr 19, 2023
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
@adamjmcgrath
Copy link
Contributor

lgtm - thanks @Will956

@adamjmcgrath adamjmcgrath merged commit ca51bd3 into auth0:master Apr 19, 2023
@adamjmcgrath adamjmcgrath mentioned this pull request Apr 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjmcgrath adamjmcgrath adamjmcgrath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Will956 @adamjmcgrath