-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK-2155] Default cookie.secure config to the protocol of baseURL #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panva
reviewed
Dec 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, i'm leaving some text suggestions.
Co-authored-by: Filip Skokan <panva.ip@gmail.com>
panva
approved these changes
Dec 3, 2020
adamjmcgrath
added a commit
to auth0/nextjs-auth0
that referenced
this pull request
Dec 8, 2020
Closed
FPiety0521
pushed a commit
to FPiety0521/Auth0-Next.js-SDK
that referenced
this pull request
Apr 28, 2023
redsky030428
added a commit
to redsky030428/autho_next.js
that referenced
this pull request
May 13, 2024
luckyshinystar7
pushed a commit
to luckyshinystar7/nextjs-crysdyazandco
that referenced
this pull request
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Default the
cookie.secure
config to the protocol of thebaseUrl
config - rather than defaulting it to the protocol of thereq.url
(which relies on the developer to set trust proxy when behind a proxy)And a couple of other things that should improve the DX around this setting:
cookie.secure
totrue
andbaseUrl
ishttp
- throw an error, because this will not work (your secure cookies won't be read over http)cookie.secure
tofalse
andbaseUrl
ishttps
- warn the user that the cookie will not be set with the Secure attributebaseUrl
ishttp
andresponse_mode
isform_post
- warn the use that this will only work for <2min logins (have also added an FAQ for this)References
Chrome 2 min exception for Lax+POST https://www.chromium.org/updates/same-site
fixes #145
Testing
Checklist
master