Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing base64url dependency #180

Merged
merged 1 commit into from
Jan 20, 2021
Merged

missing base64url dependency #180

merged 1 commit into from
Jan 20, 2021

Conversation

adamjmcgrath
Copy link
Contributor

base64url is indirectly referenced through openid-client but you require it directly in your own code.

fixes #179

@adamjmcgrath adamjmcgrath requested a review from a team as a code owner January 18, 2021 15:49
@adamjmcgrath adamjmcgrath added the review:tiny Tiny review label Jan 18, 2021
@davidpatrick davidpatrick merged commit 79d0261 into master Jan 20, 2021
@davidpatrick davidpatrick deleted the base64url-dep branch January 20, 2021 22:24
@alexmuller alexmuller mentioned this pull request Jan 24, 2021
Closed
@davidpatrick davidpatrick mentioned this pull request Jan 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidpatrick davidpatrick davidpatrick approved these changes

@alck11 alck11 alck11 approved these changes

Assignees
No one assigned
Labels
CH: Fixed review:tiny Tiny review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please add base64url to dependencies for use with YARN 2 packager
3 participants
@adamjmcgrath @alck11 @davidpatrick