Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prompt should be passed as an auth param #217

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Prompt should be passed as an auth param #217

merged 1 commit into from
Apr 9, 2021

Conversation

adamjmcgrath
Copy link
Contributor

Description

silentLogin was not "silent", because prompt=none was not being passed correctly to login

References

fixes #212

Testing

Have added a regression test to assert that prompt=none is passed to the /authorize endpoint.

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@adamjmcgrath adamjmcgrath added the review:small Small review label Apr 9, 2021
@adamjmcgrath adamjmcgrath requested a review from a team as a code owner April 9, 2021 09:49
@adamjmcgrath adamjmcgrath mentioned this pull request Apr 9, 2021
Closed
@adamjmcgrath adamjmcgrath merged commit d1ed72f into master Apr 9, 2021
@adamjmcgrath adamjmcgrath deleted the fix-silent-login branch April 9, 2021 11:25
@dkleber89 dkleber89 mentioned this pull request Apr 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehobbsdev stevehobbsdev stevehobbsdev approved these changes

Assignees
No one assigned
Labels
review:small Small review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

attemptSilentLogin option prompt login page on very first request of public page
2 participants
@adamjmcgrath @stevehobbsdev