Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(patch): Added httpTimeout Option #251

Merged
merged 4 commits into from
Jun 29, 2021

Conversation

jmacvey
Copy link
Contributor

@jmacvey jmacvey commented Jun 25, 2021

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Facilitates httpTimeout configuration option (in milliseconds) on ConfigParams interface. This allows package consumers to configure the http timeout for requests against less-than-performant issuers.

References

Closes #249.

Testing

Language: Javascript
Node Versions Tested: 12.19.0

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@jmacvey jmacvey requested a review from a team as a code owner June 25, 2021 18:30
@jmacvey
Copy link
Contributor Author

jmacvey commented Jun 25, 2021

Note: I have not updated documentation explicitly in .html files under docs folder. I'm assuming there's a tool/bot that does that, but if not I'll do it manually. Please let me know.

@adamjmcgrath adamjmcgrath merged commit 0f434fb into auth0:master Jun 29, 2021
@adamjmcgrath
Copy link
Contributor

Thanks @jmacvey!

@adamjmcgrath adamjmcgrath mentioned this pull request Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow configuration of oidc client timeout
2 participants