Issue 227 - allow custom session id generation #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit address [issue 227](auth0#227) allowing an implementation of genid to be used when a custom session store is used. This is fully compatibile with the existing implementation and aligns with how expression-session allows for overriding the way session ids are generated. Note because of how session ids are generated in this library, it is not possible to simply fall into the custom store's genid function. In implementing these changes, the following was done: - Moved the default session id generation into config to make it clear what said default is - Added a new parameter genid compatible with how it works for express-session - Updated the appsession code to take advantage of the provided value and fallback to the default. - Added unit tests validating the genid parameter being used when specified and not having any effect on the encrypted cookie implementation. - Reordered the spread operators in the appsession custom store tests so that overrides are respected. This changed no other existing tests. - Updated documentation with the additional, optional parameter along with links to the compatabile usage in express-session.
adamjmcgrath
approved these changes
Jun 29, 2021
|
Thanks @nholik! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
This commit address issue
227 allowing an implementation of genid to be used when a custom session store is used. This is fully compatible with the existing implementation and aligns with how expression-session allows for overriding the way session ids are generated. Note because of how session ids are generated in this library, it is not possible to simply fall into the custom store's genid function.
In implementing these changes, the following was done:
References
See discussion in this issue #227
Also https://github.com/expressjs/session#genid
Testing
Tested with node 14
Checklist
master