add typescript types #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jbarrus - Thank you so much for this! We'll take a look this week and get back to you with feedback or an approval. |
joshcanhelp
suggested changes
Oct 8, 2019
jbarrus
force-pushed
the
typescript-types
branch
from
a05772c to
c5e2c5d
Compare
3 tasks
joshcanhelp
approved these changes
Oct 10, 2019
There was a problem hiding this comment.
@jbarrus Thank you once again! We may need to tinker with this a bit down the road and we will likely switch this project to TS so we can use annotations but this was a great addition! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
Adds typescript definitions to allow easier use with typescript projects.
References
https://www.typescriptlang.org/docs/handbook/declaration-files/introduction.html
Testing
Testing can be done by importing into a typescript project.
Checklist
master