Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default leeway and re-write API documentation #30

Merged
merged 4 commits into from
Oct 16, 2019
Merged

Update default leeway and re-write API documentation #30

merged 4 commits into from
Oct 16, 2019

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Oct 11, 2019 •
edited
Loading

Description

  • Rewrite API.md and EXAMPLE.md for format, clarity, and accuracy
  • Increase default leeway to 60 seconds.

@joshcanhelp joshcanhelp changed the title Update config options Update default leeway and re-write API documantation Oct 11, 2019
@joshcanhelp joshcanhelp added this to the v0.5.0 milestone Oct 11, 2019
@joshcanhelp joshcanhelp marked this pull request as ready for review October 15, 2019 13:36
@joshcanhelp joshcanhelp added the review:medium Medium review label Oct 15, 2019
@joshcanhelp joshcanhelp requested a review from a team October 15, 2019 13:36
@joshcanhelp joshcanhelp changed the title Update default leeway and re-write API documantation Update default leeway and re-write API documentation Oct 15, 2019
stevehobbsdev
stevehobbsdev reviewed Oct 16, 2019
View reviewed changes
Copy link

@stevehobbsdev stevehobbsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving the doc rewrite, much clearer!

Just left a couple of very minor spelling/wording things :)

API.md Outdated Show resolved Hide resolved
EXAMPLES.md Outdated Show resolved Hide resolved
@joshcanhelp joshcanhelp merged commit 796a447 into auth0:master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehobbsdev stevehobbsdev stevehobbsdev approved these changes

Assignees
No one assigned
Labels
CH: Changed review:medium Medium review
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@joshcanhelp @stevehobbsdev