Add cross domain iframe support for modern browsers #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging bc2902c into 73d50df - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 8aab1e0 into c1b1b0c - view on LGTM.com new alerts:
|
adamjmcgrath
commented
Jan 28, 2022
| @@ -213,7 +214,8 @@ module.exports = (config) => { | |||
| ) { | |||
| const hasPrevSession = !!req[COOKIES][sessionName]; | |||
| const replacingPrevSession = !!req[REGENERATED_SESSION_ID]; | |||
| const hasCurrentSession = req[sessionName] && Object.keys(req[sessionName]).length; | |||
| const hasCurrentSession = | |||
There was a problem hiding this comment.
These whitespace changes are from a previous prettier update
…frame-skip-silent-login
|
This pull request introduces 1 alert when merging 523a5e9 into c1b1b0c - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging da84e1e into 48526b1 - view on LGTM.com new alerts:
|
stevehobbsdev
approved these changes
Jan 31, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing crossdomain iframe login/logout and attemptSilentAuth support. This can be enabled by using
session.cookie.sameSite = 'None'andsession.cookie.secure = true(you should run localhost on https for this see: https://auth0.com/docs/libraries/secure-local-development)References
fixes #315
Testing
To test login/logout from a cross domain iframe:
caddy reverse-proxy --from localhost:443 --to localhost:3000baseUrlset tohttps://localhosthttp://localhost:3000/iframe(running same app on a different domain to the iframe, which is onhttps://localhost)auth_verificationtransaction cookies have been removedappSessioncookie has been removedChecklist
master