Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow periods in cookie name #350

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Conversation

moberegger
Copy link
Contributor

@moberegger moberegger commented Apr 4, 2022

Description

Similar to #330, this PR relaxes the validation on the cookie name by allowing .s. As per https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie#attributes, this should be allowed.

I stumbled into this issue migrating over from express-session, which uses connect.sid as the default cookie name. I saw that #330 relaxed this to allow for -, so figured I'd do the same for ..

References

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie#attributes

Testing

Added a new my.session value to test against in the test setup provided by #330.

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@moberegger moberegger requested a review from a team as a code owner April 4, 2022 20:53
@adamjmcgrath
Copy link
Contributor

Thanks @moberegger!

@adamjmcgrath adamjmcgrath merged commit 50132d4 into auth0:master Apr 5, 2022
@adamjmcgrath adamjmcgrath mentioned this pull request Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants