Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to #330, this PR relaxes the validation on the cookie name by allowing
.
s. As per https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie#attributes, this should be allowed.I stumbled into this issue migrating over from
express-session
, which usesconnect.sid
as the default cookie name. I saw that #330 relaxed this to allow for-
, so figured I'd do the same for.
.References
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie#attributes
Testing
Added a new
my.session
value to test against in the test setup provided by #330.Checklist
master