-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK-3808] Optionally sign the session store cookie #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
reviewed
Nov 16, 2022
Widcket
reviewed
Nov 16, 2022
Widcket
reviewed
Nov 16, 2022
Widcket
reviewed
Nov 16, 2022
lib/crypto.js
Outdated
return !!JWS.verify( | ||
flattenedJWSFromCookie(cookie, value, signature), | ||
keystore, | ||
{ algorithm: 'HS256', crit: ['b64'] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any way to not duplicate these values that are already used in the header
constant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 have moved these into constants
Also, noticed a typo - thanks
Widcket
approved these changes
Nov 16, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an option
signSessionStoreCookie
(defaultfalse
) - when true and using a custom session store, the session store cookie will be signed. e.g.The default session id is a cryptographically secure random value, but this is useful when you want to override
genid
and you are only generating a unique value, not a cryptographically secure random value.Also adding a
requireSignedSessionStoreCookie
config option to allow zero down time migration to signed session store cookies.fafa0e0 The first commit is just moving some code into another file to make it easier to share
d1c3dc0 This is the main commit that implements signed session store cookies
References
express-session docs
genid
Testing
Checklist