Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on cb lib #424

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

kmannislands
Copy link
Contributor

Description

Remove dependency on 10 year old cb library. The downside of the supply chain security vector of this lib (especially when used in sensitive middle ware like this) outweighs the trivial utility that express-oidc-connect was getting from the dependency. It was being used only to memoize callbacks in 3 locations.

References

Closes #423

Testing

All unit tests passing should cover this change as it is very straight-forward. Code inspection of the cb lib indicated that this should behave identically.

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@kmannislands kmannislands requested a review from a team as a code owner November 29, 2022 00:21
Copy link
Contributor

@adamjmcgrath adamjmcgrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kmannislands

@adamjmcgrath adamjmcgrath merged commit 44aa3cf into auth0:master Nov 29, 2022
@adamjmcgrath adamjmcgrath mentioned this pull request Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants