Merge seperate config schemas #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
joshcanhelp
commented
Jan 23, 2020
| assert.equal(parsed.query.redirect_uri, 'https://example.org/callback'); | ||
| assert.property(parsed.query, 'nonce'); | ||
| assert.property(parsed.query, 'state'); | ||
| }); | ||
|
|
||
| it('should contain the two callbacks route', function() { | ||
| assert.ok(router.stack.some(filterRoute('GET', '/callback'))); | ||
| assert.ok(router.stack.some(filterRoute('POST', '/callback'))); |
There was a problem hiding this comment.
This was a remnant of fragment support. id_token with an undefined response_mode defaults to fragment which is not supported in this SDK.
joshcanhelp
commented
Jan 23, 2020
| @@ -104,7 +104,7 @@ describe('invalid parameters', function() { | |||
| httpOnly: '__invalid_httponly__' | |||
There was a problem hiding this comment.
Error message changes only in this file.
joshcanhelp
commented
Jan 23, 2020
| @@ -44,7 +43,7 @@ describe('logout route', function() { | |||
|
|
|||
| it('should redirect to the base url', function() { | |||
| assert.equal(logoutResponse.statusCode, 302); | |||
| assert.equal(logoutResponse.headers.location, 'https://example.org/'); | |||
| assert.equal(logoutResponse.headers.location, 'https://example.org'); | |||
joshcanhelp
commented
Jan 23, 2020
| const config = getConfig(customConfig); | ||
|
|
||
| it('should keep token code', function() { | ||
| assert.equal(config.authorizationParams.response_type, 'token id_token code'); |
There was a problem hiding this comment.
Does not exactly match metadata fixture so this would have thrown before.
stevehobbsdev
approved these changes
Jan 27, 2020
Co-Authored-By: Steve Hobbs <steve.hobbs.mail@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
appSessionCookieschema into main config schema to remove double-processingauthorizationParamsschema into main config schema to remove double-processingresponse_type=form_postifresponse_modecontainstokenorid_token; change defaultpostLogoutRedirectUrito not append trailing slashresponse_typeto respect content rather than exact match against issuer metadataloadEnvfunctionality into config.jsclientSecretrequired checks into Joiwhen()statementsReferences