-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register Express as a peer dependency #63
Conversation
@stevehobbsdev, please rebase |
@stevehobbsdev - Thanks for this! The Quickstart and sample need to be updated as well |
d72c0cc
to
5ce1ec1
Compare
@joshcanhelp What needs to happen on the sample? I can't see where these changes would affect anything there. Will submit a change to the quickstart now. @lbalmaceda I've rebased, looks like CI is fixed 👍 |
@joshcanhelp Actually it looks like the quickstart is correct. |
@stevehobbsdev probably Josh meant: |
Done, PRs attached. |
Both merged now. I'll merge this one as well 👍 |
Description
This PR:
appSessionKey
should beappSessionSecret
Rationale
The peer dependency of Express is useful because:
cookie@0.4.0
, which is the minimum version ofcookie
that supports the SameSite attributeexpress-generator
still installsexpress@4.16
by default which brings in a lower version ofcookie
that does not support the SameSite attributeexpress@>= 4.17.0
as a peer dependency means that at least the user will get a warning when they try to install itexpress
indevDependencies
Checklist
master