Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove returnTo parameter for logout #72

Merged
merged 2 commits into from
Mar 2, 2020
Merged

Remove returnTo parameter for logout #72

merged 2 commits into from
Mar 2, 2020

Conversation

joshcanhelp
Copy link
Contributor

Description

Remove the returnTo parameter from the logout URL to avoid redirecting logged-in users to an externally-defined URL.

@joshcanhelp joshcanhelp requested a review from a team March 2, 2020 18:11
@joshcanhelp joshcanhelp added this to the v0.8.1 milestone Mar 2, 2020
gkwang
gkwang approved these changes Mar 2, 2020
View reviewed changes
Copy link

@gkwang gkwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for making the change.

@joshcanhelp joshcanhelp merged commit 8551436 into master Mar 2, 2020
@joshcanhelp joshcanhelp deleted the fix-open-redirect-issue branch March 2, 2020 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkwang gkwang gkwang approved these changes

Assignees
No one assigned
Labels
CH: Fixed review:tiny Tiny review
Projects
None yet
Milestone
v0.8.1
Development

Successfully merging this pull request may close these issues.
2 participants
@joshcanhelp @gkwang