Fix returnTo on Login #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When no returnTo is passed into the login call, it should redirect to the URL that it was called from on GET Requests. This is in line with documentation at https://github.com/auth0/express-openid-connect/blob/master/API.md#response
adamjmcgrath
approved these changes
May 4, 2020
Merged
|
This has regressed with v2. It now redirects to the baseUrl, and not (what i think should be) the referrer. express-openid-connect/middleware/auth.js Line 42 in 1d33b74 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no returnTo is passed into the login call, it should redirect to the URL that it was called from on GET Requests.
This is in line with documentation at https://github.com/auth0/express-openid-connect/blob/master/API.md#response