Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to pass a custom audience when using client credentials #106

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Add ability to pass a custom audience when using client credentials #106

merged 1 commit into from
Aug 23, 2022

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Aug 23, 2022 •
edited
Loading

Description

In this PR we add the ability to pass a custom audience when using client credentials. This is especially useful when using custom domains that are not publicly accessible.

References

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have read and agreed to the terms within the Auth0 Code of Conduct.
  • I have read the Auth0 General Contribution Guidelines.
  • I have reviewed my own code beforehand.
  • I have added documentation for new/changed functionality in this PR.
  • All active GitHub checks for tests, formatting, and security are passing.
  • The correct base branch is being used, if not main.

@sergiught sergiught marked this pull request as ready for review August 23, 2022 15:32
@sergiught sergiught requested a review from a team as a code owner August 23, 2022 15:32
@sergiught sergiught self-assigned this Aug 23, 2022
@sergiught sergiught mentioned this pull request Aug 23, 2022
Closed
6 tasks
Base automatically changed from patch/rearrange-management-file to main August 23, 2022 15:42
willvedd
willvedd approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, glad you were able to bang that out!

@sergiught sergiught merged commit 7b6dd90 into main Aug 23, 2022
@sergiught sergiught deleted the feature/custom-audience branch August 23, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willvedd willvedd willvedd approved these changes

Assignees

@sergiught sergiught

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergiught @willvedd