Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-243: Improve precision of branding theme fields with float64 instead of int #121

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

sergiught
Copy link
Contributor

🔧 Changes

Change types from int to float32 for increased precision on branding theme fields.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught self-assigned this Oct 14, 2022
@sergiught sergiught marked this pull request as ready for review October 14, 2022 12:50
@sergiught sergiught requested a review from a team as a code owner October 14, 2022 12:50
@sergiught sergiught force-pushed the patch/DXCDT-243-branding-theme-precision branch from 5026d74 to 114ca7f Compare October 14, 2022 13:11
@sergiught sergiught changed the title DXCDT-243: Improve precision of branding theme fields with float32 instead of int DXCDT-243: Improve precision of branding theme fields with float64 instead of int Oct 14, 2022
@sergiught sergiught merged commit d266916 into main Oct 17, 2022
@sergiught sergiught deleted the patch/DXCDT-243-branding-theme-precision branch October 17, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants