Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mixpanel log stream #133

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

inhumantsar
Copy link
Contributor

🔧 Changes

  • This adds a log stream type and sink for Mixpanel

🔬 Testing

  • This does not include a recording for tests. I wasn't sure if adding one using my tenant and modifying the URL to use the go-auth0 tenant was appropriate.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

Please let me know if I missed anything. Happy to add it. Would like this functionality to use with the Terraform provider.

@sergiught
Copy link
Contributor

Hey @inhumantsar 👋🏻 thanks for the contribution 🥳

We will need however to add those integration tests as well. The tests will automatically swap out any url domain you're using with the one used within the tests "go-auth0-dev.eu.auth0.com".

And we're also missing the generated accessor methods for the new sink type. You can simply run make generate for those.

After these changes it would be great if you could override the go.mod in auth0/terraform-provider-auth0#408 to test against these changes as well. e.g. go get github.com/auth0/go-auth0@<commitHashFromThisPR>

Let us know if you need any help with the above.

@sergiught sergiught force-pushed the feature/mixpanel-log-streams branch from 9da1782 to dd4e35d Compare December 14, 2022 13:05
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2022

Codecov Report

Base: 95.30% // Head: 95.32% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (848e2b0) compared to base (db1c505).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
+ Coverage   95.30%   95.32%   +0.01%     
==========================================
  Files          38       38              
  Lines        6392     6416      +24     
==========================================
+ Hits         6092     6116      +24     
  Misses        241      241              
  Partials       59       59              
Impacted Files Coverage Δ
management/log_stream.go 81.15% <100.00%> (+0.56%) ⬆️
management/management.gen.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sergiught sergiught force-pushed the feature/mixpanel-log-streams branch from dd4e35d to 848e2b0 Compare December 14, 2022 13:11
@sergiught
Copy link
Contributor

Hey @inhumantsar 👋🏻 I had some time and was able to get this PR in the right place. Let me know if you have any questions 🙇🏻

@sergiught sergiught merged commit 01b002b into auth0:main Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants