Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-4235] Generate safe getters for map[string]interface types #205

Merged
merged 3 commits into from
May 16, 2023
Merged

[SDK-4235] Generate safe getters for map[string]interface types #205

merged 3 commits into from
May 16, 2023

Conversation

ewanharris
Copy link
Contributor

🔧 Changes

Adds support for generating safe getters for map[string]interface types, this means that the SDK can generate a safe getter for all types used

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@ewanharris ewanharris requested a review from a team as a code owner May 15, 2023 16:23
sergiught
sergiught approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@sergiught sergiught left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪🏻

@ewanharris ewanharris merged commit d38cc8d into beta May 16, 2023
@ewanharris ewanharris deleted the build/generate-getters-for-map-string-interface branch May 16, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiught sergiught sergiught approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewanharris @sergiught