Fix UpdateCredential func #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
=======================================
Coverage 95.00% 95.01%
=======================================
Files 38 38
Lines 7026 7038 +12
=======================================
+ Hits 6675 6687 +12
Misses 280 280
Partials 71 71
☔ View full report in Codecov by Sentry. |
sergiught
force-pushed
the
patch/fix-update-client-creds
branch
from
e08e00e
to
bc4e488
Compare
ewanharris
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
This PR fixes an unmarshal issue with the UpdateCredential func, where after patching it, the client credential doesn't get the response unmarshalled into the credential var passed by reference.
📚 References
🔬 Testing
📝 Checklist