Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-4335] Add passwordless authentication APIs #229

Merged
merged 5 commits into from
Jun 21, 2023

Conversation

ewanharris
Copy link
Contributor

🔧 Changes

This implements the passwordless APIs on the authentication client:

  • SendEmail
  • LoginWithEmail
  • SendSMS
  • LoginWithSMS

📚 References

🔬 Testing

Covered by tests and test email manually. Currently testing SMS once I get twilio working

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@ewanharris ewanharris requested a review from a team as a code owner June 21, 2023 11:18
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2023

Codecov Report

Patch coverage: 92.10% and project coverage change: -0.02 ⚠️

Comparison is base (ba79baa) 94.61% compared to head (6758e87) 94.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             beta     #229      +/-   ##
==========================================
- Coverage   94.61%   94.60%   -0.02%     
==========================================
  Files          43       44       +1     
  Lines        8098     8136      +38     
==========================================
+ Hits         7662     7697      +35     
- Misses        341      343       +2     
- Partials       95       96       +1     
Impacted Files Coverage Δ
authentication/passwordless.go 91.89% <91.89%> (ø)
authentication/authentication.go 89.09% <100.00%> (+0.20%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ewanharris ewanharris force-pushed the feat/SDK-4335-passwordless branch from c2a76d9 to 6dd94c0 Compare June 21, 2023 11:44
@ewanharris ewanharris requested a review from Widcket June 21, 2023 13:31
Copy link
Contributor

@Widcket Widcket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewanharris ewanharris merged commit c8737f6 into beta Jun 21, 2023
@ewanharris ewanharris deleted the feat/SDK-4335-passwordless branch June 21, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants