-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK-4335] Add passwordless authentication APIs #229
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## beta #229 +/- ##
==========================================
- Coverage 94.61% 94.60% -0.02%
==========================================
Files 43 44 +1
Lines 8098 8136 +38
==========================================
+ Hits 7662 7697 +35
- Misses 341 343 +2
- Partials 95 96 +1
☔ View full report in Codecov by Sentry. |
ewanharris
force-pushed
the
feat/SDK-4335-passwordless
branch
from
June 21, 2023 11:44
c2a76d9
to
6dd94c0
Compare
Widcket
reviewed
Jun 21, 2023
Widcket
reviewed
Jun 21, 2023
Widcket
reviewed
Jun 21, 2023
Widcket
reviewed
Jun 21, 2023
Widcket
reviewed
Jun 21, 2023
Widcket
reviewed
Jun 21, 2023
Widcket
reviewed
Jun 21, 2023
Widcket
approved these changes
Jun 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
This implements the passwordless APIs on the authentication client:
📚 References
🔬 Testing
Covered by tests and test email manually. Currently testing SMS once I get twilio working
📝 Checklist