-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Custom Prompt Support #341
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would also be great to start draft PRs within the auth0-cli and terraform provider as well with this functionality, before we merge this PR. To validate that we're indeed building the best API possible.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #341 +/- ##
==========================================
- Coverage 94.93% 94.78% -0.16%
==========================================
Files 47 47
Lines 9081 9124 +43
==========================================
+ Hits 8621 8648 +27
- Misses 348 359 +11
- Partials 112 117 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment around the naming to ensure we're consistent with documentation/naming of the feature
fbdac56
to
24a5ae6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks @m3talsmith!
We can merge but hold on releasing to ensure we need no API changes
Wow, Great!!!! |
🔧 Changes
📚 References
🔬 Testing
Unit tests added into the normal flow. Make test should cover it.
📝 Checklist