Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Custom Prompt Support #341

Merged
merged 16 commits into from
Feb 1, 2024
Merged

Conversation

m3talsmith
Copy link
Contributor

🔧 Changes

  • Adds support for Custom Prompts to Management

📚 References

🔬 Testing

Unit tests added into the normal flow. Make test should cover it.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@m3talsmith m3talsmith marked this pull request as ready for review January 29, 2024 18:51
@m3talsmith m3talsmith requested a review from a team as a code owner January 29, 2024 18:51
Copy link
Contributor

@sergiught sergiught left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would also be great to start draft PRs within the auth0-cli and terraform provider as well with this functionality, before we merge this PR. To validate that we're indeed building the best API possible.

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (4173045) 94.93% compared to head (3683da4) 94.78%.

Files Patch % Lines
management/prompt.go 60.97% 11 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #341      +/-   ##
==========================================
- Coverage   94.93%   94.78%   -0.16%     
==========================================
  Files          47       47              
  Lines        9081     9124      +43     
==========================================
+ Hits         8621     8648      +27     
- Misses        348      359      +11     
- Partials      112      117       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m3talsmith m3talsmith requested a review from sergiught February 1, 2024 16:35
Copy link
Contributor

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment around the naming to ensure we're consistent with documentation/naming of the feature

Copy link
Contributor

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @m3talsmith!

@ewanharris ewanharris dismissed sergiught’s stale review February 1, 2024 21:41

We can merge but hold on releasing to ensure we need no API changes

@ewanharris ewanharris merged commit f9765fc into auth0:main Feb 1, 2024
7 checks passed
@Arturs1123
Copy link

Wow, Great!!!!

@sergiught sergiught mentioned this pull request Feb 28, 2024
2 tasks
@ewanharris ewanharris mentioned this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants