[GH-358] Bug Fix sending "null" body in unnecessary requests #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
developerkunal
changed the title
developerkunal
changed the title
sergiught
reviewed
Apr 22, 2024
Comment on lines
76
to
77
| assert.Error(t, err) | ||
| assert.Contains(t, err.Error(), testCase.expectedError.Error()) |
There was a problem hiding this comment.
Any chance we can make the expectedError a string and then use assert.EqualError instead? This would reduce the assertions to just 1 line.
| if testCase.expectedError != nil { | ||
| assert.Error(t, err) | ||
| assert.Contains(t, err.Error(), testCase.expectedError.Error()) | ||
| assert.Nil(t, request) |
There was a problem hiding this comment.
We could return immediately after this assert and then remove the else block.
| }{ | ||
| { | ||
| name: "Valid GET request", | ||
| method: "GET", |
There was a problem hiding this comment.
Any chance we could use the constants from the http package for the methods? http.MethodGet
Comment on lines
84
to
87
| if testCase.method == "GET" || testCase.method == "DELETE" { | ||
| requestBody, _ := io.ReadAll(request.Body) | ||
| assert.Empty(t, string(requestBody)) | ||
| } |
There was a problem hiding this comment.
We could remove these conditional checks inside the assertions if we have an expectedBody on the testCases as well and then simply do an assert.Equal.
| transfer_encoding: [] | ||
| trailer: {} | ||
| host: go-auth0-dev.eu.auth0.com | ||
| remote_addr: "" | ||
| request_uri: "" | ||
| body: | | ||
| null | ||
| body: "" |
sergiught
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
📚 References
🔬 Testing
📝 Checklist