-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for attributes
and precedence
to ConnectionOptions & phone_number
to SignupRequest Struct
#421
Add Support for attributes
and precedence
to ConnectionOptions & phone_number
to SignupRequest Struct
#421
Conversation
…umber to SignupRequest Struct
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #421 +/- ##
==========================================
+ Coverage 95.44% 95.51% +0.07%
==========================================
Files 47 47
Lines 7725 7848 +123
==========================================
+ Hits 7373 7496 +123
Misses 235 235
Partials 117 117 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
}, | ||
} | ||
|
||
func TestConnectionManager_CreateDBConnectionWithDifferentOptions(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How easy is it to figure out which test case is failing with this code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
🔧 Changes
attributes
andprecedence
fields toConnectionOptions
struct in the management package.phone_number
field toSignupRequest
struct in the authentication package to allow user signup with phone number.📚 References
🔬 Testing
The following test cases have been added to ensure the new functionality works as expected:
Authentication Package
Database.Signup
method with a connection that requires a username.Database.Signup
method with a connection that requires an email.Database.Signup
method with a connection that requires a username.Database.Signup
method with a connection that requires both a username and email.Database.Signup
method with a connection that requires a phone number.Database.Signup
method with a connection that requires both a username and phone number.Database.Signup
method with a connection that requires a username, email, and phone number.Management Package
ConnectionOptions
:📝 Checklist