Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing support for Custom email provider in EmailProviderManager #452

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

duedares-rvj
Copy link
Contributor

@duedares-rvj duedares-rvj commented Oct 7, 2024

🔧 Changes

  • Add support for Custom email provider in EmailProviderManager

📚 References

🔬 Testing

  • Performed manual testing to verify functionality.
  • Added unit tests for JSON marshalling.

Example

emailProvider: &EmailProvider{
          Name:               auth0.String("custom"),
          Enabled:            auth0.Bool(true),
          DefaultFromAddress: auth0.String("accounts@example.com"),
          Credentials:        &EmailProviderCredentialsCustom{},
}

err := api.EmailProvider.Create(context.Background(), emailProvider)
if err != nil {
    if err.(Error).Status() != http.StatusConflict {
	    t.Error(err)
    }
}

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@duedares-rvj duedares-rvj requested a review from a team as a code owner October 7, 2024 08:47
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.81%. Comparing base (831f015) to head (55d6bab).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #452   +/-   ##
=======================================
  Coverage   95.81%   95.81%           
=======================================
  Files          51       51           
  Lines        8456     8461    +5     
=======================================
+ Hits         8102     8107    +5     
  Misses        236      236           
  Partials      118      118           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@developerkunal developerkunal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@developerkunal developerkunal changed the title Added support for custom email provider Add support for Custom email provider in EmailProviderManager Oct 7, 2024
@duedares-rvj duedares-rvj merged commit 49eb8e1 into main Oct 7, 2024
9 checks passed
@duedares-rvj duedares-rvj deleted the feat/custom_email_provider branch October 7, 2024 09:12
@developerkunal developerkunal changed the title Add support for Custom email provider in EmailProviderManager Add missing support for Custom email provider in EmailProviderManager Oct 7, 2024
@developerkunal developerkunal mentioned this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants