Adding several missing tenant flags #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
sergiught
reviewed
Jun 30, 2022
| @@ -198,6 +198,42 @@ type TenantFlags struct { | |||
| // If enabled, this will use the scope description when generating a consent | |||
| // prompt. Otherwise, the scope name is used. | |||
| UseScopeDescriptionsForConsent *bool `json:"use_scope_descriptions_for_consent,omitempty"` | |||
|
|
|||
| // Whether the legacy delegation endpoint will be enabled for your account (true) or not available (false). | |||
| AllowLegacyDelegationGrantTypes *bool `json:"allow_legacy_delegation_grant_types,omitempty"` | |||
There was a problem hiding this comment.
Let's not add any legacy enabling flags or dashboard flags, it's extremely unlikely they'll ever be used. Let's just keep:
- EnableIDTokenAPI2
- NoDisclosureEnterpriseConnections
- DisableManagementAPISMSObfuscation
- EnableADFSWAADEmailVerification
- RevokeRefreshTokenGrant
- DisableFieldsMapFix
There was a problem hiding this comment.
Update: Discussed this internally, we're gonna stay consistent with the auth0 docs.
sergiught
approved these changes
Jun 30, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding the following feature flags to the tenant resource:
allow_legacy_delegation_grant_typesallow_legacy_ro_grant_typesallow_legacy_tokeninfo_endpointenable_legacy_profileenable_idtoken_api2no_disclose_enterprise_connectionsdisable_management_api_sms_obfuscationenable_adfs_waad_email_verificationrevoke_refresh_token_grantdashboard_log_streams_nextdashboard_insights_viewdisable_fields_map_fixThese were all the missing flags from the API docs plus an additional requested feature flag.
This is not meant to be an exhaustive list of feature flags; there are several other feature flags that have varying degrees of support depending on the tenants. It is inevitable that we'll continually need to update this list. However, this is meant to give an honest effort about updating the support.
References
disable_management_api_sms_obfuscationflagTesting
Checklist
main.