Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding PKCE enablement field to OAuth2 connection options #82

Merged
merged 2 commits into from
Jul 5, 2022
Merged

Adding PKCE enablement field to OAuth2 connection options #82

merged 2 commits into from
Jul 5, 2022

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Jun 30, 2022 •
edited
Loading

Description

Adding the pkce_enabled field for OAuth2 connection options which controls the enablement of Proof Key for Code Exchange (PKCE).

References

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have read and agreed to the terms within the Auth0 Code of Conduct.
  • I have read the Auth0 General Contribution Guidelines.
  • I have reviewed my own code beforehand.
  • I have added documentation for new/changed functionality in this PR.
  • All active GitHub checks for tests, formatting, and security are passing.
  • The correct base branch is being used, if not main.

@willvedd willvedd requested a review from a team as a code owner June 30, 2022 12:45
@willvedd willvedd mentioned this pull request Jul 2, 2022
Merged
8 tasks
@sergiught sergiught merged commit b8f2476 into main Jul 5, 2022
@sergiught sergiught deleted the add-pkce-oauth2-connection-options branch July 5, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiught sergiught sergiught approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willvedd @sergiught