Changed arrays to use short array syntax #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
suggested changes
Dec 19, 2018
There was a problem hiding this comment.
Thanks again @dmyers! Looks like you got all of the old array() literals here. Could I ask you to also bump the PHP requirement in composer.json to 5.4 as well? Laravel 5 requires that and we've already got the short array syntax in a few places so this would already break on older PHP installs.
|
Sorry for delayed response. Good idea. I just made PR #118 that can be merged before this one for that. |
joshcanhelp
approved these changes
Jan 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.