Change the visibility of the getter method from private to public

[irieznykov]

Changes

I have changed the visibility of the getter method from private to public. I think this makes a sense because the $auth0 variable is private and its getter is private so there is no ability to get auth0 SDK using Auth0Service. In my case, I need access to the getRefreshToken() method of the SDK because this method was not realized in the service but I need to use the same instance of the SDK which used in methods getUser(), getIdToken().

[joshcanhelp]

@irieznykov - Thank you for the PR and thoughtful description here!

I understand the use case here and we're re-thinking the architecture in this module currently but I wonder if it would be better, at this point, to just add the method that you need instead of changing the visibility of this accessor. If you need the refresh token, you can add this method instead:

class Auth0Service
{
    // ...
    public function getRefreshToken()
    {
        return $this->getSDK()->getRefreshToken();
    }
    // ..
}

[irieznykov]

Thank you for the replying @joshcanhelp
Agree with you. But, anyway, on my mind, there is no sense to have the private variable and the private getter for it. So, maybe, you can change the visibility to protected at least? This will allow someones to have the ability to interact with the same SDK instance in the child class from the Auth0Service. Please let me know if I can do something with the changes and create the PR for you otherwise I'm waiting for the changes from you.

[joshcanhelp]

@irieznykov - In my mind, the idea here is not to expose the entire SDK but just parts of it you might need, hence the specific accessor methods. I think making the whole thing public does more harm than good as the rest of the functionality there is not needed in this context.

If you feel strongly, I'll spend some time reviewing the implications here. Otherwise, if you switch to what I'm suggesting above, I can get this merged in.

[irieznykov]

Hey @joshcanhelp I've changed back the visibility for the getter and have added the new method getRefreshToken() inside service, could you please take a look?

[joshcanhelp]

Clean and simple, works for me!