Return null instead of false in Auth0UserProvider. #128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Return null instead of false from
validateCredentials
,retrieveByToken
andretrieveByCredentials
, in Auth0UserProvider.Why
Because of this function in Illuminate\Auth\GuardHelpers:
This caused issues for us when we migrated to auth0, as some of our users utilized remember_token in previous login system.
Which caused Auth0UserProvider
retrieveByToken
to be called, and returnedfalse
user, which laravel counts as a "logged in user".Which then caused exception when code asked for $user->stuff on a boolean.
In our case, only
retrieveByToken
was called, but it makes sense to me thatretrieveByCredentials
andvalidateCredentials
also should return null instead of false.