Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cachehandler resolving issues #131

Merged
merged 1 commit into from
Jun 26, 2019
Merged

Fix cachehandler resolving issues #131

merged 1 commit into from
Jun 26, 2019

Conversation

anthonyvancauwenberghe
Copy link
Contributor

This PR fixes the cachehandler to always return null

@anthonyvancauwenberghe anthonyvancauwenberghe requested a review from a team June 26, 2019 16:16
joshcanhelp
joshcanhelp approved these changes Jun 26, 2019
View reviewed changes
Copy link
Contributor

@joshcanhelp joshcanhelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

@joshcanhelp joshcanhelp added this to the v5-Next milestone Jun 26, 2019
@joshcanhelp joshcanhelp merged commit 125d297 into auth0:master Jun 26, 2019
@anthonyvancauwenberghe
Copy link
Contributor Author

Noproblem!
Would you mind publishing a new patch release for this? This was a pretty serious flaw that comes with performance penalties in production environments.

@joshcanhelp
Copy link
Contributor

@deviouspk - Absolutely. We're about due for one anyways. I'll push it out tomorrow morning 👍

@joshcanhelp
Copy link
Contributor

@deviouspk - I have the release up on GitHub but Packagist removed a legacy package update method we were using. We're working to get the package moved under our official user there but, hopefully, the release here will help. I'll stay on it and ping this thread when it's live there. Thanks for your patience!

@joshcanhelp
Copy link
Contributor

Update complete!

https://packagist.org/packages/auth0/login#5.2.0

@anthonyvancauwenberghe
Copy link
Contributor Author

thankyou!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joshcanhelp joshcanhelp joshcanhelp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anthonyvancauwenberghe @joshcanhelp