Replace setEnvironment with setEnvProperty
#145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was deprecated in Auth0 SDK 5.4.0
Since the ServiceProvider does more than just registering services it cannot be used for deffered loading.
joshcanhelp
approved these changes
Oct 7, 2019
joshcanhelp
changed the title
setEnvironment with setEnvPropertysetEnvironment with setEnvProperty
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey again 👋
I wondered through the code and saw some small changes. Let me know if you agree. I'd be happy to change anything :)
Changes
setEnvironmentwithsetEnvPropertysince it was marked deprecated in the SDKTesting
Let's check the integration with a running Laravel application. I
Checklist
I have read the Auth0 general contribution guidelines
I have read the Auth0 Code of Conduct