Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Middleware contract has been deprecated in 5.1 #19

Merged
merged 1 commit into from
Oct 27, 2015

Conversation

thijsvdanker
Copy link
Contributor

See http://laravel.com/docs/master/upgrade#upgrade-5.1.0

The middleware contract is deprecated in 5.1 and will be removed in 5.2 (due december 2015).

@glena
Copy link
Contributor

glena commented Oct 26, 2015

@thijsvdanker Thanks, I miss the latest changes. This guy keeps changing things that makes BC problems :@

I am not sure if this can bring problems with 5.0, I think it force you to implement the interface. Doesn't it?

I think I will create a decorator for 5.0 that wraps this class without the contract, how does it sound?

@luceos
Copy link

luceos commented Oct 26, 2015

There should be no issue removing the interface. The interface only defines the necessary methods a class should have. Also if your concern is related to IoC binding, I can tell you that an interface is not required for the class to be bound into it.

Also supporting 5.1 is a bit more valuable, seeing it is the Long Term Support (LTS) version. But it's up to you to find the correct solution in your package. Good luck and nice work!

@glena
Copy link
Contributor

glena commented Oct 26, 2015

Thanks @luceos, the thing is that I wasn't sure if the middleware pipeline explicitly check for middleware subtypes, if this is not the case it shouldn't be a problem.

I will check the Laravel docs and implementation in 5.0 and then merge this PR.

Thanks guys

glena added a commit that referenced this pull request Oct 27, 2015
Middleware contract has been deprecated in 5.1
@glena glena merged commit 0e936c2 into auth0:master Oct 27, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants