Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for PHP 8.0 #200

Merged
merged 17 commits into from
Jan 11, 2021
Merged

Support for PHP 8.0 #200

merged 17 commits into from
Jan 11, 2021

Conversation

evansims
Copy link
Member

@evansims evansims commented Nov 23, 2020 •
edited
Loading

This branch includes work necessary for the SDK to run on the release of PHP 8.0.

  • Bumps minimum supported PHP version from 7.2 to 7.3
  • PHPUnit dependency bumped to 9.3 (from 7) as older releases will not work with PHP 8
  • Updates unit tests for syntax changes in PHPUnit 9
  • Drops support for Laravel 5, which is EOL and will not have PHP 8 support backported
  • Adds static code analysis to testing steps
  • Updates coding standards to more closely match the PHP SDK
  • Performs a formatting pass using these updated standards
  • Update CircleCI tests to more closely match the PHP SDK and test across a broader number of PHP releases

@evansims evansims mentioned this pull request Dec 28, 2020
Closed
@evansims evansims changed the title Support for PHP 8 Support for PHP 8.0 Jan 4, 2021
@evansims evansims marked this pull request as ready for review January 4, 2021 19:41
@evansims evansims requested a review from a team as a code owner January 4, 2021 19:41
@evansims evansims added the small label Jan 4, 2021
lbalmaceda
lbalmaceda approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evansims remember the changelog label and milestone.

@evansims evansims merged commit 0cc3517 into master Jan 11, 2021
@evansims evansims deleted the update-php8 branch January 11, 2021 18:50
@evansims evansims removed the small label Jan 11, 2021
@evansims evansims added this to the 6.2.0 milestone Jan 11, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@evansims @lbalmaceda