Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the missing return null; in getUserByIdentifier #201

Merged
merged 2 commits into from
Jan 11, 2021

Conversation

sebwas
Copy link
Contributor

@sebwas sebwas commented Dec 1, 2020

Changes

I added an explicit return null; to the end of the getUserByIdentifier method of Auth0\Login\Repository\Auth0UserRepository.

References

The code otherwise is invalid and results in an exception in some cases. For reference, consider this very simple example.

image

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

[x] This change has been tested on the latest version Laravel

Checklist

[x] I have read the Auth0 general contribution guidelines

[x] I have read the Auth0 Code of Conduct

@sebwas sebwas requested a review from a team as a code owner December 1, 2020 14:56
@evansims evansims self-requested a review December 1, 2020 20:00
evansims
evansims previously approved these changes Dec 1, 2020
Copy link
Member

@evansims evansims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@evansims evansims merged commit 4b01094 into auth0:master Jan 11, 2021
@evansims evansims added this to the 6.2.0 milestone Jan 11, 2021
@evansims
Copy link
Member

Thanks @sebwas, your contribution was merged and will be part of the next release 👍

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants