Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-2318] feat: Store changes made to the user object during the onLogin event hook #206

Merged
merged 1 commit into from
Feb 17, 2021

Conversation

evansims
Copy link
Member

Ensure changes made to the user object during the onLogin event hook are stored and propagated for later use, as suggested here.

@evansims evansims requested a review from a team as a code owner February 16, 2021 22:53
@evansims evansims added this to the 6.3.0 milestone Feb 16, 2021
@evansims evansims merged commit 7ffa11f into master Feb 17, 2021
@evansims evansims deleted the feat-sdk-2318 branch February 17, 2021 13:03
@JoeyHoutenbos
Copy link

@frederikprijck with this change the onLogin callback now has to return an array instead of Auth0\Login\Auth0User object.
But an array obviously doesn't implement the Illuminate\Contracts\Auth\Authenticatable class which is required for the Auth::login(...) call here: https://github.com/auth0/laravel-auth0/blob/master/src/controllers/Auth0Controller.php#L51

So I don't get how this is supposed to work. Could you please help me out?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants