Remove the facade aliases usage since they can be removed/changed fro… #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m the Laravel configuration which will make impossible to install and use the plugin.
evansims
reviewed
Apr 27, 2021
| @@ -37,7 +37,7 @@ public function getUserByUserInfo(array $userInfo) : Authenticatable | |||
| public function getUserByIdentifier($identifier) : ?Authenticatable | |||
| { | |||
| // Get the user info of the user logged in (probably in session) | |||
| $user = \App::make('auth0')->getUser(); | |||
| $user = \Illuminate\Support\Facades\App::make('auth0')->getUser(); | |||
There was a problem hiding this comment.
This appears to be throwing an error with our tests. Any ideas on how to work around this?
evansims
reviewed
Apr 27, 2021
| @@ -21,11 +21,11 @@ class LoginServiceProvider extends ServiceProvider | |||
| */ | |||
| public function boot() | |||
| { | |||
| \Auth::provider('auth0', function ($app, array $config) { | |||
| \Illuminate\Support\Facades\Auth::provider('auth0', function ($app, array $config) { | |||
There was a problem hiding this comment.
Would it be possible to import these with use statements at the top of the file as opposed to going the inline route? Not sure if this was a technical requirement, just curious if that would be a cleaner approach otherwise.
|
Hey, @Rezouce! 👋 Thanks for your PR — I think this is a reasonable suggestion. I've left a few comments. |
…oid having the full classname.
…we're not using the alias anymore
evansims
approved these changes
Apr 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Use the fully qualified facade class names instead of their aliases which allow using the plugin even when for some reason the default aliases have been removed or replaced (ie. legacy code usage).
Testing
[x] This change has been tested on the latest version Laravel
Checklist
[x] I have read the Auth0 general contribution guidelines
[x] I have read the Auth0 Code of Conduct