Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel Octane Support #218

Merged
merged 3 commits into from
Jul 27, 2021
Merged

Laravel Octane Support #218

merged 3 commits into from
Jul 27, 2021

Conversation

oozman
Copy link

@oozman oozman commented Jun 2, 2021

Changes

A code changes that relates to Laravel Octane support. Please see change files for more info.

References

See: #212

Testing

Recommend to test it in a Laravel Octane server.

Note

When binding Auth0UserRepository contract in your AppServiceProvider, the second parameter should be a closure returning the concrete class. See example below:

$this->app->bind(
    \Auth0\Login\Contract\Auth0UserRepository::class,
    function() {
        return new \Auth0\Login\Repository\Auth0UserRepository();
    }
);

@oozman oozman requested a review from a team as a code owner June 2, 2021 12:47
@evansims
Copy link
Member

evansims commented Jun 2, 2021

Hey @oozman 👋 Thanks so much, this looks exciting! I'm currently deep in wrapping up with on the 8.0 branch of the PHP SDK so give me a little to finish that up and I'll turn my attention to reviewing this and making sure it syncs with the API changes happening there, as I'd like to slip this in with a new major of the Laravel library along with that. Hang tight! Thank you again, I really appreciate the contribution

@evansims evansims self-assigned this Jun 2, 2021
@evansims evansims self-requested a review June 2, 2021 18:48
@evansims evansims added this to the 7.0.0 milestone Jun 2, 2021
@oozman
Copy link
Author

oozman commented Jun 3, 2021

Thanks :)

@evansims evansims closed this Jul 27, 2021
@evansims evansims reopened this Jul 27, 2021
@evansims evansims changed the base branch from main to 7.0.0-dev July 27, 2021 13:29
Copy link
Member

@evansims evansims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to this, @oozman. 👍 I'm going to go ahead and merge this into the 7.x branch, where work around the next major will be taking place.

@evansims evansims merged commit 89461a4 into auth0:7.0.0-dev Jul 27, 2021
@tyler-koch-sw
Copy link

@oozman Any updates on Octane support for Auth0? Many are still receiving this error: Auth0 \ SDK \ Exception \ StateException "Missing code" PHP 8.1.8 Laravel 9.21.0

@evansims
Copy link
Member

evansims commented Aug 8, 2022

@oozman Any updates on Octane support for Auth0? Many are still receiving this error: Auth0 \ SDK \ Exception \ StateException "Missing code" PHP 8.1.8 Laravel 9.21.0

Thanks for the heads-up @tyler-koch-sw; this issue had not been reported, and I was unaware of it. Sorry about that! I've just merged a PR with a fix for this, and I'll cut a new release containing it yet this week.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants